linux-kernel - Re: [PATCH] drm/amd/display: remove unintended executable mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0d3f57c-416c-6a6a-0e9e-d3dc308f2b52@amd.com>
Date:   Wed, 19 Aug 2020 10:53:22 +0200
From:   Christian König <christian.koenig@....com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        Dennis Li <Dennis.Li@....com>, Jerry Zuo <Jerry.Zuo@....com>
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Guchun Chen <guchun.chen@....com>,
        Hersen Wu <hersenxs.wu@....com>
Subject: Re: [PATCH] drm/amd/display: remove unintended executable mode

Am 19.08.20 um 10:18 schrieb Lukas Bulwahn:
> Besides the intended change, commit 4cc1178e166a ("drm/amdgpu: replace DRM
> prefix with PCI device info for gfx/mmhub") also set the source files
> mmhub_v1_0.c and gfx_v9_4.c to be executable, i.e., changed fromold mode
> 644 to new mode 755.
>
> Commit 241b2ec9317e ("drm/amd/display: Add dcn30 Headers (v2)") added the
> four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e.,
> mode 755.
>
> Set to the usual modes for source and headers files and clean up those
> mistakes. No functional change.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
> applies cleanly on current master and next-20200819
>
> Alex, Christian, please pick this minor non-urgent cleanup patch.

Alex is usually the one picking those up. If he misses something feel 
free to ping us once more.

Thanks,
Christian.

>
> Dennis, Jerry, please ack.
>
> Dennis, Jerry, you might want to check your development environment
> introducing those executable modes on files.
>
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c                         | 0
>   drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c                       | 0
>   drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h   | 0
>   drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h  | 0
>   drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h  | 0
>   drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0
>   6 files changed, 0 insertions(+), 0 deletions(-)
>   mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c
>   mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
>   mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h
>   mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h
>   mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h
>   mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c
> old mode 100755
> new mode 100644
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
> old mode 100755
> new mode 100644
> diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h
> old mode 100755
> new mode 100644
> diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h
> old mode 100755
> new mode 100644
> diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h
> old mode 100755
> new mode 100644
> diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
> old mode 100755
> new mode 100644