lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Aug 2020 10:05:03 +0800 From: Zhen Lei <thunder.leizhen@...wei.com> To: Oliver O'Halloran <oohall@...il.com>, Dan Williams <dan.j.williams@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, "Dave Jiang" <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>, Markus Elfring <Markus.Elfring@....de>, linux-nvdimm <linux-nvdimm@...ts.01.org>, linux-kernel <linux-kernel@...r.kernel.org> CC: Zhen Lei <thunder.leizhen@...wei.com> Subject: [PATCH v2 4/4] libnvdimm/region: reduce an unnecessary if branch in nd_region_create() The "else" branch can only be entered when ndr_desc->flush is NULL. After replaced "NULL" with "ndr_desc->flush", we will find that the statements in "if..else.." are the same. No functional change. Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com> --- drivers/nvdimm/region_devs.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index ef23119db574663..7cf9c7d857909ce 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -1131,10 +1131,7 @@ static struct nd_region *nd_region_create(struct nvdimm_bus *nvdimm_bus, nd_region->ndr_size = resource_size(ndr_desc->res); nd_region->ndr_start = ndr_desc->res->start; nd_region->align = default_align(nd_region); - if (ndr_desc->flush) - nd_region->flush = ndr_desc->flush; - else - nd_region->flush = NULL; + nd_region->flush = ndr_desc->flush; nd_device_register(dev); -- 1.8.3
Powered by blists - more mailing lists