linux-kernel - Re: [PATCH] fs: Add function declaration of simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200819114755.GC17456@casper.infradead.org>
Date:   Wed, 19 Aug 2020 12:47:55 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: Add function declaration of simple_dname

On Wed, Aug 19, 2020 at 02:40:01PM +0300, Leon Romanovsky wrote:
> On Wed, Aug 19, 2020 at 12:34:24PM +0100, Matthew Wilcox wrote:
> > On Wed, Aug 19, 2020 at 11:32:59AM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@...dia.com>
> > >
> > > The simple_dname() is declared in internal header file as extern
> > > and this generates the following GCC warning.
> >
> > The fact that it's declared as extern doesn't matter.  You don't need
> > the change to internal.h at all.  The use of 'extern' on a function
> > declaration is purely decorative:
> >
> >   5 If the declaration of an identifier for a function has no
> >   storage-class specifier, its linkage is determined exactly as if it
> >   were declared with the storage-class specifier extern.
> 
> So why do we need to keep extern keyword if we use intenral.h directly?

We don't.  It's just personal preference.  I don't use extern keywords
on function declarations anywhere, but Al does and it's rude to change it.