linux-kernel - Re: [PATCH net] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <210d463e-e444-66a6-62f3-e39e0940d5f9@huawei.com>
Date:   Wed, 19 Aug 2020 10:41:30 +0800
From:   "wanghai (M)" <wanghai38@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <ulli.kroll@...glemail.com>, <linus.walleij@...aro.org>,
        <kuba@...nel.org>, <mirq-linux@...e.qmqm.pl>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: gemini: Fix missing free_netdev() in error path
 of gemini_ethernet_port_probe()


在 2020/8/19 3:54, David Miller 写道:
> From: Wang Hai <wanghai38@...wei.com>
> Date: Tue, 18 Aug 2020 21:44:04 +0800
>
>> Fix the missing free_netdev() before return from
>> gemini_ethernet_port_probe() in the error handling case.
>>
>> Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> You can just convert this function to use 'devm_alloc_etherdev_mqs', which
> is a one line fix.
>
> .
Thanks for your advice, I just sent a v2 patch.
"[PATCH net v2] net: gemini: Fix missing free_netdev() in error path of 
gemini_ethernet_port_probe()"