linux-kernel - Re: [PATCH 14/20] media: dvb-frontends: lgdt3306a.c: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <378b3a76-1d14-8c69-f9be-3749e6c3c083@xs4all.nl>
Date:   Wed, 19 Aug 2020 15:35:30 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     "Daniel W. S. Almeida" <dwlsalmeida@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     skhan@...uxfoundation.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 14/20] media: dvb-frontends: lgdt3306a.c: remove dead code

On 07/08/2020 10:35, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
> 
> Fix the following coccinelle report:
> 
> drivers/media/dvb-frontends/lgdt3306a.c:718:5-8:
> Unneeded variable: "ret". Return "0" on line 744
> 
> Code was enclosed with #if 0 and thus this variable was not needed.
> Remove that code altogether.
> 
> Found using - Coccinelle (http://coccinelle.lip6.fr)
> 
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@...il.com>
> ---
>  drivers/media/dvb-frontends/lgdt3306a.c | 27 +------------------------
>  1 file changed, 1 insertion(+), 26 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
> index d3c330e035c4..0247ef799546 100644
> --- a/drivers/media/dvb-frontends/lgdt3306a.c
> +++ b/drivers/media/dvb-frontends/lgdt3306a.c
> @@ -715,33 +715,8 @@ static int lgdt3306a_spectral_inversion(struct lgdt3306a_state *state,
>  				       struct dtv_frontend_properties *p,
>  				       int inversion)
>  {
> -	int ret = 0;
> -
>  	dbg_info("(%d)\n", inversion);
> -#if 0
> -	/*
> -	 * FGR - spectral_inversion defaults already set for VSB and QAM;
> -	 * can enable later if desired
> -	 */
> -
> -	ret = lgdt3306a_set_inversion(state, inversion);
> -
> -	switch (p->modulation) {
> -	case VSB_8:
> -		/* Manual only for VSB */
> -		ret = lgdt3306a_set_inversion_auto(state, 0);
> -		break;
> -	case QAM_64:
> -	case QAM_256:
> -	case QAM_AUTO:
> -		/* Auto ok for QAM */
> -		ret = lgdt3306a_set_inversion_auto(state, 1);
> -		break;
> -	default:
> -		ret = -EINVAL;
> -	}
> -#endif
> -	return ret;
> +	return 0;
>  }
>  
>  static int lgdt3306a_set_if(struct lgdt3306a_state *state,
> 

You can drop the lgdt3306a_spectral_inversion function completely
since the function doesn't do anything. It would be good to replace
the function call with the comment "spectral_inversion defaults already
set for VSB and QAM" so that information isn't lost.

Regards,

	Hans