linux-kernel - RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7538540ab82e4b398a0203564a1f1b23@paragon-software.com>
Date:   Thu, 20 Aug 2020 10:20:26 +0000
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Aurélien Aptel <aaptel@...e.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon
 Software.

From: Aurélien Aptel <aaptel@...e.com>
Sent: Friday, August 14, 2020 5:09 PM
> 
> Hi Konstantin,
> 
> That's cool :) As Nikolay said it needs a little change to the makefiles
> to even build.
> 
> Are you also going to publish your own mkfs.ntfs3 tool? I dont think the
> existing one would support 64k clusters.

Hi Aurélien. Thanks for your feedback. We plan to publish our mkfs.ntfs utility as the open source as well (and possibly fschk.ntfs - after mkfs). 

> 
> I would recommend to run checkpatch (I see already 87 warnings... some
> of it is noise):
> 
>   $ ./scripts/checkpatch.pl <patch>
> 
> And sparse (I dont see much):
> 
>   $ touch fs/ntfs3/*.[ch] && make C=1
> 
> You need a recent build of sparse to do that last one. You can pass your
> own sparse bin (make CHECK=~/prog/sparse/sparse C=1)
> 
> This will be a good first step.

The sparse utility is running against the code, as well as checkpatch.pl. Sprase output is clean now. Checkpatch's somehow important warnings will be fixed in v2 (except maybe typedefs). 

> 
> Have you tried to run the xfstests suite against it?
>
xfstests are being one of our standard test suites among others. Currently we have the 'generic/339' and 'generic/013' test cases failing, working on it now. Other tests either pass or being skipped (due to missing features e.g. reflink). 
 
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)