linux-kernel - Re: [PATCH v32 07/12] LRNG - add kernel crypto API PRNG extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202008202059.U74Vt4ft%lkp@intel.com>
Date:   Thu, 20 Aug 2020 20:32:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stephan Müller <smueller@...onox.de>,
        Arnd Bergmann <arnd@...db.de>
Cc:     kbuild-all@...ts.01.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Alexander E. Patrakov" <patrakov@...il.com>,
        "Ahmed S. Darwish" <darwish.07@...il.com>,
        "Theodore Y. Ts'o" <tytso@....edu>, Willy Tarreau <w@....eu>
Subject: Re: [PATCH v32 07/12] LRNG - add kernel crypto API PRNG extension

Hi "Stephan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on cryptodev/master crypto/master v5.9-rc1 next-20200820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200820-165712
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git d162219c655c8cf8003128a13840d6c1e183fb80
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/char/lrng/lrng_kcapi.c:295:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
     295 | const static struct lrng_crypto_cb lrng_kcapi_crypto_cb = {
         | ^~~~~

# https://github.com/0day-ci/linux/commit/808fe83c881534a108058461be3f9a0706d0c423
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200820-165712
git checkout 808fe83c881534a108058461be3f9a0706d0c423
vim +/static +295 drivers/char/lrng/lrng_kcapi.c

   294	
 > 295	const static struct lrng_crypto_cb lrng_kcapi_crypto_cb = {
   296		.lrng_drng_name			= lrng_kcapi_drng_name,
   297		.lrng_hash_name			= lrng_kcapi_pool_hash,
   298		.lrng_drng_alloc		= lrng_kcapi_drng_alloc,
   299		.lrng_drng_dealloc		= lrng_kcapi_drng_dealloc,
   300		.lrng_drng_seed_helper		= lrng_kcapi_drng_seed_helper,
   301		.lrng_drng_generate_helper	= lrng_kcapi_drng_generate_helper,
   302		.lrng_hash_alloc		= lrng_kcapi_hash_alloc,
   303		.lrng_hash_dealloc		= lrng_kcapi_hash_dealloc,
   304		.lrng_hash_digestsize		= lrng_kcapi_hash_digestsize,
   305		.lrng_hash_buffer		= lrng_kcapi_hash_buffer,
   306	};
   307	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (57273 bytes)