linux-kernel - Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200820123711.GA19989@bogus>
Date:   Thu, 20 Aug 2020 13:37:11 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Sumit Gupta <sumitg@...dia.com>, rjw@...ysocki.net,
        catalin.marinas@....com, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-pm@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, bbasu@...dia.com,
        wangkefeng.wang@...wei.com, Sudeep Holla <sudeep.holla@....com>
Subject: Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir

On Thu, Aug 20, 2020 at 11:09:45AM +0530, Viresh Kumar wrote:
> On 12-08-20, 01:13, Sumit Gupta wrote:
> > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
> > fixes the issue with building tegra194 cpufreq driver as module. But
> > the fix might cause problem while supporting physical cpu hotplug[1].
> > 
> > This patch fixes the original problem by avoiding use of cpu_logical_map().
> > Instead calling read_cpuid_mpidr() to get MPIDR on target cpu.
> > 
> > [1] https://lore.kernel.org/linux-arm-kernel/20200724131059.GB6521@bogus/
> > 
> > Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> > Signed-off-by: Sumit Gupta <sumitg@...dia.com>
> > ---
> >  drivers/cpufreq/tegra194-cpufreq.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> Applied. Thanks.

Just to confirm, is this going as a fix ? We want to drop exporting
cpu_logical_map in v5.9 so this needs to go as fix. I missed it earlier,
actually,

Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver")
is appropriate here so that we can drop export symbol which was part of
Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
as a workaround to  fix the build.

-- 
Regards,
Sudeep