linux-kernel - Re: [PATCH v2 16/17] arm64: dts: imx8mp: Add media_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA+hA=S6j71M-Bjbkm1C+q6Ke7xGUX3K0TosKwWJ=tegFaBGsQ@mail.gmail.com>
Date:   Thu, 20 Aug 2020 09:31:27 +0800
From:   Dong Aisheng <dongas86@...il.com>
To:     Abel Vesa <abel.vesa@....com>
Cc:     Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Anson Huang <anson.huang@....com>,
        Jacky Bai <ping.bai@....com>, Peng Fan <peng.fan@....com>,
        Dong Aisheng <aisheng.dong@....com>,
        Fugang Duan <fugang.duan@....com>,
        devicetree <devicetree@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v2 16/17] arm64: dts: imx8mp: Add media_blk_ctrl node

Hi Rob, Stephen,

On Thu, Aug 20, 2020 at 4:37 AM Abel Vesa <abel.vesa@....com> wrote:
>
> On 20-08-18 19:34:14, Dong Aisheng wrote:
> > On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa <abel.vesa@....com> wrote:
> > >
> > > Some of the features of the media_ctrl will be used by some
> > > different drivers in a way those drivers will know best, so adding the
> > > syscon compatible we allow those to do just that. Only the resets
> > > and the clocks are registered bit the clk-blk-ctrl driver.
> > >
> > > Signed-off-by: Abel Vesa <abel.vesa@....com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > index dede0ae..2d6d213 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > @@ -736,6 +736,22 @@
> > >                         };
> > >                 };
> > >
> > > +               aips4: bus@...00000 {
> > > +                       compatible = "simple-bus";
> > > +                       reg = <0x32c00000 0x400000>;
> > > +                       #address-cells = <1>;
> > > +                       #size-cells = <1>;
> > > +                       ranges;
> > > +
> > > +                       media_blk_ctrl: clock-controller@...c0000 {
> >
> > For this combo device, maybe we can directly name it as blk-ctrl@...c0000.
> > Rob, do you think if we can do that?
> >
>
> I think it was Stephen who suggested we change it to clock-controller in the
> last's version thread.
>
> TBH, I agree with you here, since it makes more sense to be called blk-ctrl
> provided that this is not really just a clock controller.
>

How do you think?

Regards
Aisheng

> > > +                               compatible = "fsl,imx8mp-media-blk-ctrl", "syscon";
> > > +                               reg = <0x32ec0000 0x10000>;
> > > +
> >
> > Remove unnecessary blank line
> >
>
> Will do.
>
> > Otherwise:
> > Reviewed-by: Dong Aisheng <aisheng.dong@....com>
> >
> > Regards
> > Aisheng
> >
> > > +                               #clock-cells = <1>;
> > > +                               #reset-cells = <1>;
> > > +                       };
> > > +               };
> > > +
> > >                 aips5: bus@...00000 {
> > >                         compatible = "fsl,aips-bus", "simple-bus";
> > >                         reg = <0x30c00000 0x400000>;
> > > --
> > > 2.7.4
> > >