linux-kernel - Re: [PATCH V7] GCOV: Add config to check the preqequisites situation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF12kFuss4AQZSBX+A2G_fWjka3C4kpf4iDWU9QJY=AWigoxqg@mail.gmail.com>
Date:   Thu, 20 Aug 2020 20:40:53 +0800
From:   Cixi Geng <gengcixi@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>, jslaby@...e.com,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        linux-serial@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Orson Zhai <orsonzhai@...il.com>, zhang.lyra@...il.com,
        Cixi Geng <cixi.geng1@...soc.com>
Subject: Re: [PATCH V7] GCOV: Add config to check the preqequisites situation

Hi All:

Does this patch need more modification?

<gengcixi@...il.com> 于2020年7月27日周一 下午4:51写道：
>
> From: Cixi Geng <cixi.geng1@...soc.com>
>
> Introduce new configuration option GCOV_PROFILE_PREREQS that can be
> used to check whether the prerequisites for enabling gcov profiling
> for specific files and directories are met.
>
> Only add SERIAL_GCOV for an example.
>
> Signed-off-by: Cixi Geng <cixi.geng1@...soc.com>
> ---
>  drivers/tty/serial/Kconfig  |  7 +++++++
>  drivers/tty/serial/Makefile |  1 +
>  kernel/gcov/Kconfig         | 12 ++++++++++++
>  3 files changed, 20 insertions(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 780908d43557..55b128b6b31d 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1576,3 +1576,10 @@ endmenu
>
>  config SERIAL_MCTRL_GPIO
>         tristate
> +
> +config SERIAL_GCOV
> +       bool "Enable profile gcov for serial directory"
> +       depends on GCOV_PROFILE_PREREQS
> +       help
> +         The SERIAL_GCOV will add Gcov profiling flags when kernel compiles.
> +         Say 'Y' here if you want the gcov data for the serial directory,
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index d056ee6cca33..17272733db95 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -3,6 +3,7 @@
>  # Makefile for the kernel serial device drivers.
>  #
>
> +GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
>  obj-$(CONFIG_SERIAL_CORE) += serial_core.o
>
>  obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> index 3110c77230c7..bb2e1fb85743 100644
> --- a/kernel/gcov/Kconfig
> +++ b/kernel/gcov/Kconfig
> @@ -51,4 +51,16 @@ config GCOV_PROFILE_ALL
>         larger and run slower. Also be sure to exclude files from profiling
>         which are not linked to the kernel image to prevent linker errors.
>
> +config GCOV_PROFILE_PREREQS
> +       bool "Profile Kernel for prereqs"
> +       depends on GCOV_KERNEL
> +       depends on  !COMPILE_TEST
> +       def_bool y if GCOV_KERNEL && !COMPILE_TEST
> +       help
> +         This options activates profiling for the specified kernel modules.
> +
> +         When some modules need Gcov data, enable this config, then configure
> +         with gcov on the corresponding modules,The directories or files of
> +         these modules will be added profiling flags after kernel compile.
> +
>  endmenu
> --
> 2.17.1
>