linux-kernel - Re: [PATCH] uacce: Use kobj_to_dev() instead of container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f2bbd04-79fa-95e6-50ec-e0dd270f6c61@linaro.org>
Date:   Thu, 20 Aug 2020 10:52:50 +0800
From:   Zhangfei Gao <zhangfei.gao@...aro.org>
To:     Tian Tao <tiantao6@...ilicon.com>, wangzhou1@...ilicon.com,
        arnd@...db.de, gregkh@...uxfoundation.org,
        linux-accelerators@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc:     linuxarm@...wei.com
Subject: Re: [PATCH] uacce: Use kobj_to_dev() instead of container_of()



On 2020/8/20 上午10:16, Tian Tao wrote:
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> Reviewed-by: Zhou Wang <wangzhou1@...ilicon.com>
Acked-by: Zhangfei Gao <zhangfei.gao@...aro.org>

Thanks
> ---
>   drivers/misc/uacce/uacce.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index a5b8dab..a9da7b1 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -370,7 +370,7 @@ static struct attribute *uacce_dev_attrs[] = {
>   static umode_t uacce_dev_is_visible(struct kobject *kobj,
>   				    struct attribute *attr, int n)
>   {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>   	struct uacce_device *uacce = to_uacce_device(dev);
>   
>   	if (((attr == &dev_attr_region_mmio_size.attr) &&