linux-kernel - Re: [PATCH 2/9] sched,idle,rcu: Push rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Aug 2020 09:58:48 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org, will@...nel.org,
        npiggin@...il.com, elver@...gle.com, jgross@...e.com,
        paulmck@...nel.org, rjw@...ysocki.net, joel@...lfernandes.org,
        svens@...ux.ibm.com, tglx@...utronix.de
Subject: Re: [PATCH 2/9] sched,idle,rcu: Push rcu_idle deeper into the idle
 path

On Thu, 20 Aug 2020 09:30:33 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> +++ b/drivers/cpuidle/cpuidle.c
> @@ -145,22 +145,27 @@ static void enter_s2idle_proper(struct c

[..]
>  	drv->states[index].enter_s2idle(dev, drv, index);
> -	WARN_ON(!irqs_disabled());
> +	if (WARN_ON(!irqs_disabled()))
> +		local_irq_disable();
>  	/*

This looks like a fix that should go in as a separate patch. As it
looks unrelated to this patch.

-- Steve