linux-kernel - Re: [PATCH] x86/pci: fix xen.c build error when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200820144020.GA31230@char.us.oracle.com>
Date:   Thu, 20 Aug 2020 10:40:20 -0400
From:   Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:     Randy Dunlap <rdunlap@...radead.org>, jgross@...e.com,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-pci <linux-pci@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        xen-devel <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not
 set

On Wed, Aug 19, 2020 at 08:09:11PM -0700, Randy Dunlap wrote:
> Hi Konrad,

Hey Randy,

I believe Juergen is picking this up.
> 
> ping.
> 
> I am still seeing this build error. It looks like this is
> in your territory to merge...
> 
> 
> On 8/13/20 4:00 PM, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@...radead.org>
> > 
> > Fix build error when CONFIG_ACPI is not set/enabled:
> > 
> > ../arch/x86/pci/xen.c: In function ‘pci_xen_init’:
> > ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
> >   acpi_noirq_set();
> > 
> > Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> > Cc: xen-devel@...ts.xenproject.org
> > Cc: linux-pci@...r.kernel.org
> > ---
> >  arch/x86/pci/xen.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- linux-next-20200813.orig/arch/x86/pci/xen.c
> > +++ linux-next-20200813/arch/x86/pci/xen.c
> > @@ -26,6 +26,7 @@
> >  #include <asm/xen/pci.h>
> >  #include <asm/xen/cpuid.h>
> >  #include <asm/apic.h>
> > +#include <asm/acpi.h>
> >  #include <asm/i8259.h>
> >  
> >  static int xen_pcifront_enable_irq(struct pci_dev *dev)
> > 
> 
> 
> thanks.
> -- 
> ~Randy
>