linux-kernel - Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <217e3c0c.b58c.17409fd7496.Coremail.dinghao.liu@zju.edu.cn>
Date:   Thu, 20 Aug 2020 11:50:39 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Lee Jones" <lee.jones@...aro.org>
Cc:     "Markus Elfring" <Markus.Elfring@....de>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        "Bartlomiej Zolnierkiewicz" <b.zolnierkie@...sung.com>,
        "Bryan Wu" <cooloney@...il.com>,
        "Daniel Thompson" <daniel.thompson@...aro.org>,
        "Gyungoh Yoo" <jack.yoo@...worksinc.com>,
        "Jingoo Han" <jingoohan1@...il.com>, "Kangjie Lu" <kjlu@....edu>
Subject: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference
 count imbalance on error

> On Wed, 19 Aug 2020, Markus Elfring wrote:
> 
> > > When of_property_read_u32_array() returns an error code,
> > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > 
> > Can another imperative wording be helpful for the change description?
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > 
> > Would an other commit message be a bit nicer?
> > 
> > 
> > …
> > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > >  					num_entry);
> > >  		if (ret < 0) {
> > >  			dev_err(dev, "led-sources node is invalid.\n");
> > > +			of_node_put(np);
> > >  			return ERR_PTR(-EINVAL);
> > >  		}
> > 
> > I propose to add the jump target “put_node” so that a bit of common exception
> > handling code can be better reused at the end of this function implementation.
> > 
> > Regards,
> > Markus
> 
> You can safely ignore any review comments from Markus!
> 
> However, this patch doesn't appear to be in my inbox.
> 
> Any ideas as to why?
> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

Thank you for your advice. My outbox shows that this patch
has reached your email server successfully. Maybe this
ended up in your junk mail file?

Regards,
Dinghao