linux-kernel - Re: [PATCH] mm/highmem: Clean up endif comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200820163138.GC752365@kernel.org>
Date:   Thu, 20 Aug 2020 19:31:38 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     ira.weiny@...el.com
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/highmem: Clean up endif comments

On Wed, Aug 19, 2020 at 11:46:35AM -0700, ira.weiny@...el.com wrote:
> From: Ira Weiny <ira.weiny@...el.com>
> 
> The #endif at the end of the file matches up with the '#if
> defined(HASHED_PAGE_VIRTUAL)' on line 374.  Not the CONFIG_HIGHMEM #if
> earlier.
> 
> Fix comments on both of the #endif's to indicate the correct end of
> blocks for each.
> 
> Signed-off-by: Ira Weiny <ira.weiny@...el.com>

Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  mm/highmem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 64d8dea47dd1..1352a27951e3 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
>  }
>  
>  EXPORT_SYMBOL(kunmap_high);
> -#endif
> +#endif	/* CONFIG_HIGHMEM */
>  
>  #if defined(HASHED_PAGE_VIRTUAL)
>  
> @@ -481,4 +481,4 @@ void __init page_address_init(void)
>  	}
>  }
>  
> -#endif	/* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
> +#endif	/* defined(HASHED_PAGE_VIRTUAL) */
> -- 
> 2.25.1
> 
> 

-- 
Sincerely yours,
Mike.