linux-kernel - Re: [PATCH 0/9] TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200820125337.01440a50@oasis.local.home>
Date:   Thu, 20 Aug 2020 12:53:37 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     peterz@...radead.org
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org, will@...nel.org,
        npiggin@...il.com, elver@...gle.com, jgross@...e.com,
        paulmck@...nel.org, rjw@...ysocki.net, joel@...lfernandes.org,
        svens@...ux.ibm.com, tglx@...utronix.de
Subject: Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

On Thu, 20 Aug 2020 16:58:21 +0200
peterz@...radead.org wrote:

> @@ -91,11 +91,11 @@ void __cpuidle default_idle_call(void)
>  	if (current_clr_polling_and_test()) {
>  		local_irq_enable();
>  	} else {
> -		rcu_idle_enter();
>  		stop_critical_timings();
> +		rcu_idle_enter();
>  		arch_cpu_idle();
> -		start_critical_timings();
>  		rcu_idle_exit();
> +		start_critical_timings();
>  	}
>  }
>  

tip/master didn't have the above function and instead I had this:

@@ -93,11 +93,11 @@ void __cpuidle default_idle_call(void)
        } else {
 
                trace_cpu_idle(1, smp_processor_id());
-               rcu_idle_enter();
                stop_critical_timings();
+               rcu_idle_enter();
                arch_cpu_idle();
-               start_critical_timings();
                rcu_idle_exit();
+               start_critical_timings();
                trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id());
        }
 }

But it booted to completion without warning with this patch applied.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

For the entire series, with this update.

-- Steve