linux-kernel - Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <691cdbfa-d266-ec2e-e687-3ce1ca3014d8@huawei.com>
Date:   Thu, 20 Aug 2020 08:50:44 +0100
From:   John Garry <john.garry@...wei.com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Will Deacon <will@...nel.org>
CC:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Leo Yan <leo.yan@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE

On 19/08/2020 20:26, Mathieu Poirier wrote:
> On Wed, 19 Aug 2020 at 11:30, Will Deacon <will@...nel.org> wrote:
>>
>> On Wed, Aug 19, 2020 at 11:01:38AM -0600, Mathieu Poirier wrote:
>>> On Tue, 18 Aug 2020 at 11:56, John Garry <john.garry@...wei.com> wrote:
>>>> On 17/08/2020 20:31, Mathieu Poirier wrote:
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index 4e2698cc7e23..f9bb76baeec9 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -13427,8 +13427,18 @@ F:   tools/perf/
>>>>>    PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS

Maybe "PERFORMANCE EVENTS SUBSYSTEM ARM64" would be more appropriate now.

>>>>>    R:  John Garry <john.garry@...wei.com>
>>>>>    R:  Will Deacon <will@...nel.org>
>>>>> +R:   Mathieu Poirier <mathieu.poirier@...aro.org>
>>>>> +R:   Leo Yan <leo.yan@...aro.org>
>>>>>    L:  linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
>>>>>    S:  Supported
>>>>> +F:   tools/build/feature/test-libopencsd.c
>>>>> +F:   tools/perf/arch/arm/util/auxtrace.c
>>>>> +F:   tools/perf/arch/arm/util/cs-etm.*
>>>>> +F:   tools/perf/arch/arm/util/pmu.c
>>>>> +F:   tools/perf/arch/arm64/util/arm-spe.c
>>>>> +F:   tools/perf/util/arm-spe.h
>>>>> +F:   tools/perf/util/cs-etm-decoder/*
>>>>> +F:   tools/perf/util/cs-etm.*
>>>>
>>>> But from the previous discussion, I thought that we wanted an entry to
>>>> cover all tools/perf/arch/arm64/ and other related folders. Or was it
>>>> just put all special interest parts (like SPE support) under one entry
>>>> and leave the other arm/arm64 parts to be caught by "PERFORMANCE EVENTS
>>>> SUBSYSTEM" entry?
>>>
>>> I do not have the time to maintain anything outside of coresight -
>>> listing individual files as I did removes any ambiguity on that front.
>>> I'm happy to add tools/perf/arch/arm and tools/perf/arch/arm64/ if you
>>> agree to maintain them.  In that case you will have to be more
>>> specific about the "other related folders" you are referring to above.

As Leo mentioned, I was thinking of tools/perf/util/arm-spe-decoder/

>>
>> None of us have time for this, hence why I think putting us all in one entry
>> with all of the files listed there makes the most sense; then people do
>> whatever they can and try to help each other out based on how much time they
>> have. I think that's much better than fine-grained maintainership where a
>> given file has a single point of failure.
> 
> Thanks for the clarification - just wanted to make sure I don't sign
> you guys up for something you didn't agree to.

And it's "R:" level, so none of the commitment associated with "M:". In 
addition - and maybe most important - the linux-arm-kernel list will (or 
should) be cc'ed.

> 
>>
>> So I think it should include:
>>
>>    tools/perf/arch/arm64/
>>    tools/pmu-events/arch/arm64/
>>
>> along with the SPE and Coresight files.
>>
>> Arnaldo would still handle the patches, so this is really about giving us a
>> chance to review incoming patches without having to fish them out from the
>> lists.
>>
>> Will
> .
> 

Cheers,
John