linux-kernel - Re: linux-next: Fixes tag needs some work in the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Aug 2020 10:21:49 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Luca Stefani <luca.stefani.ge1@...il.com>
Subject: Re: linux-next: Fixes tag needs some work in the tip tree

On Thu, Aug 20, 2020 at 04:12:39PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   71aefb9a89d4 ("RAS/CEC: Fix cec_init() prototype")
> 
> Fixes tag
> 
>   Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")

Hmm, this came from the original patch submission:

https://lkml.kernel.org/r/20200805095708.83939-1-luca.stefani.ge1@gmail.com

the 'n' is already there.

> has these problem(s):
> 
>   - The SHA1 is not all hex

If your script which verifies that is in python, per chance, you could
give it to me so that I can add it to my patch massaging script. :-)

I have no Fixes: tags sanity checks so far and have never considered
that they could possibly be wrong but this here is a case-in-point
example.

I guess I'd need also an "is the commit ID an actual upstream commit ID"
check, while at it.

> Presumably
> 
> Fixes: 9554bfe403bd ("x86/mce: Convert the CEC to use the MCE notifier")

Fixing...

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg