linux-kernel - Re: [PATCH 11/12] regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200820163232.54b59e1d@xhacker.debian>
Date:   Thu, 20 Aug 2020 16:32:32 +0800
From:   Jisheng Zhang <Jisheng.Zhang@...aptics.com>
To:     Fabrice Gasnier <fabrice.gasnier@...com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Support Opensource <support.opensource@...semi.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Icenowy Zheng <icenowy@...c.io>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 11/12] regulator: stm32-vrefbuf: Fix W=1 build warning
 when CONFIG_OF=n

On Thu, 20 Aug 2020 10:13:12 +0200 Fabrice Gasnier wrote:

> 
> 
> On 8/20/20 9:46 AM, Jisheng Zhang wrote:
> > Fix below warning when CONFIG_OF=n:
> >
> > drivers/regulator/stm32-vrefbuf.c:287:34: warning: ‘stm32_vrefbuf_of_match’ defined but not used [-Wunused-const-variable=]
> >   287 | static const struct of_device_id stm32_vrefbuf_of_match[] = {
> >       |                                  ^~~~~~~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> > ---
> >  drivers/regulator/stm32-vrefbuf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/regulator/stm32-vrefbuf.c b/drivers/regulator/stm32-vrefbuf.c
> > index 992bc18101ef..5a5c12d9ea22 100644
> > --- a/drivers/regulator/stm32-vrefbuf.c
> > +++ b/drivers/regulator/stm32-vrefbuf.c
> > @@ -284,11 +284,13 @@ static const struct dev_pm_ops stm32_vrefbuf_pm_ops = {
> >                          NULL)
> >  };
> >
> > +#ifdef CONFIG_OF  
> 
> Hi Jisheng,

Hi,

> 
> You could probably adopt "__maybe_unused" here ? E.g. like:

__maybe_unused also fixes the warning. I'm not sure the maintainers' preference.

Hi Mark,

which solution do you prefer?

Thanks in advance

> 
> static const struct of_device_id __maybe_unused stm32_vrefbuf_of_match[] = {
> 
> I can see other drivers use this already for the same.
> 
> Thanks,
> Best regards,
> Fabrice
> 
> >  static const struct of_device_id stm32_vrefbuf_of_match[] = {
> >       { .compatible = "st,stm32-vrefbuf", },
> >       {},
> >  };
> >  MODULE_DEVICE_TABLE(of, stm32_vrefbuf_of_match);
> > +#endif
> >
> >  static struct platform_driver stm32_vrefbuf_driver = {
> >       .probe = stm32_vrefbuf_probe,
> >