linux-kernel - Re: [PATCH 2/2] x86/resctrl: Enable user to view thread or core throttling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200821171105.GA362575@otcwcpicx6.sc.intel.com>
Date:   Fri, 21 Aug 2020 17:11:05 +0000
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Tony Luck <tony.luck@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        Babu Moger <babu.moger@....com>, H Peter Anvin <hpa@...or.com>,
        x86 <x86@...nel.org>, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] x86/resctrl: Enable user to view thread or core
 throttling mode

On Fri, Aug 21, 2020 at 03:13:17PM +0200, Borislav Petkov wrote:
> On Thu, Jul 16, 2020 at 10:53:14AM -0700, Fenghua Yu wrote:
> >  struct rdt_membw {
> > +	enum membw_throttle_mode	arch_throttle_mode;
> 
> I guess "arch" is implicit so you can
> 
> s/arch_throttle_mode/throttle_mode/g
Ok. Will fix this.
> 
> ...
> 
> > +static struct rftype *rdtgroup_rftype_by_name(const char *name)
> 
> That function name needs a verb.

I will change it to rdtgroup_rftype_get_by_name().

Thank you very much for your review!

-Fenghua
> https://people.kernel.org/tglx/notes-about-netiquette