lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Aug 2020 10:35:55 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>, "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org> Cc: Pali Rohár <pali@...nel.org> Subject: Re: [PATCH v2 02/10] fs/ntfs3: Add initialization of super block On 8/21/20 9:25 AM, Konstantin Komarov wrote: > +/* O:BAG:BAD:(A;OICI;FA;;;WD) */ What is that notation, please? > +const u8 s_dir_security[] __aligned(8) = { > + 0x01, 0x00, 0x04, 0x80, 0x30, 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x14, 0x00, 0x00, 0x00, 0x02, 0x00, 0x1C, 0x00, > + 0x01, 0x00, 0x00, 0x00, 0x00, 0x03, 0x14, 0x00, 0xFF, 0x01, 0x1F, 0x00, > + 0x01, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, > + 0x01, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x20, 0x00, 0x00, 0x00, > + 0x20, 0x02, 0x00, 0x00, 0x01, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, > + 0x20, 0x00, 0x00, 0x00, 0x20, 0x02, 0x00, 0x00, > +}; > + > + if (0x10000 * sizeof(short) != inode->i_size) { > + err = -EINVAL; > + goto out; > + } Please put constants on the right side of compares. > +MODULE_AUTHOR("Konstantin Komarov"); Drop one space in the name. thanks. -- ~Randy
Powered by blists - more mailing lists