linux-kernel - Re: [PATCH] x86/pci: don't set acpi stuff if !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y2m7rc4a.fsf@nanos.tec.linutronix.de>
Date:   Fri, 21 Aug 2020 22:13:25 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Adam Borowski <kilobyte@...band.pl>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, linux-pci@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <len.brown@...el.com>
Subject: Re: [PATCH] x86/pci: don't set acpi stuff if !CONFIG_ACPI

On Thu, Aug 20 2020 at 14:53, Adam Borowski wrote:
> Not that x86 without ACPI sees any real use...
>
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>
> ---
> Found by randconfig builds.
>
>  arch/x86/pci/intel_mid_pci.c | 2 ++
>  arch/x86/pci/xen.c           | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
> index 00c62115f39c..f14a911f0d06 100644
> --- a/arch/x86/pci/intel_mid_pci.c
> +++ b/arch/x86/pci/intel_mid_pci.c
> @@ -299,8 +299,10 @@ int __init intel_mid_pci_init(void)
>  	pcibios_disable_irq = intel_mid_pci_irq_disable;
>  	pci_root_ops = intel_mid_pci_ops;
>  	pci_soc_mode = 1;
> +#ifdef CONFIG_ACPI
>  	/* Continue with standard init */
>  	acpi_noirq_set();
> +#endif

If CONFIG_ACPI=n then acpi_noirq_set() is an empty stub inline. So I'm
not sure what you are trying to solve here.

Ah, I see with CONFIG_ACPI=n linux/acpi.h does not include asm/acpi.h so
the stubs are unreachable. So that needs to be fixed and not papered
over with #ifdeffery

Thanks,

        tglx