linux-kernel - Re: [PATCH] x86/pci: don't set acpi stuff if !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85e70752-8034-ab95-f6b4-018c7086edad@infradead.org>
Date:   Fri, 21 Aug 2020 14:19:20 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Adam Borowski <kilobyte@...band.pl>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, linux-pci@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <len.brown@...el.com>
Subject: Re: [PATCH] x86/pci: don't set acpi stuff if !CONFIG_ACPI

On 8/21/20 1:32 PM, Adam Borowski wrote:
> On Fri, Aug 21, 2020 at 10:13:25PM +0200, Thomas Gleixner wrote:
>> On Thu, Aug 20 2020 at 14:53, Adam Borowski wrote:
>>> Found by randconfig builds.
>>>
>>>  arch/x86/pci/intel_mid_pci.c | 2 ++
>>>  arch/x86/pci/xen.c           | 2 ++
> 
>>> --- a/arch/x86/pci/intel_mid_pci.c
>>> +++ b/arch/x86/pci/intel_mid_pci.c
>>> @@ -299,8 +299,10 @@ int __init intel_mid_pci_init(void)
>>> +#ifdef CONFIG_ACPI
>>>  	/* Continue with standard init */
>>>  	acpi_noirq_set();
>>> +#endif
> 
>> If CONFIG_ACPI=n then acpi_noirq_set() is an empty stub inline. So I'm
>> not sure what you are trying to solve here.
>>
>> Ah, I see with CONFIG_ACPI=n linux/acpi.h does not include asm/acpi.h so
>> the stubs are unreachable. So that needs to be fixed and not papered
>> over with #ifdeffery
> 
> If I understand Randy Dunlap correctly, he already sent a pair of patches
> that do what you want.

I did, but I sent them to the Xen and PCI maintainers,
not the x86 maintainers, but I will happily resend this patch.
The Xen patch has already been applied whereas the patch
to intel_mid_pci.c is in limbo. :(

Thomas, do you want me to send it to you/X86 people?
(with 2 Reviewed-by: additions)

thanks.
-- 
~Randy