linux-kernel - Re: [RFC PATCH V3] iomap: add support to track dirty state of sub pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200821061234.GE31091@infradead.org>
Date:   Fri, 21 Aug 2020 07:12:34 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     "yukuai (C)" <yukuai3@...wei.com>
Cc:     Gao Xiang <hsiangkao@...hat.com>, hch@...radead.org,
        darrick.wong@...cle.com, willy@...radead.org, david@...morbit.com,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [RFC PATCH V3] iomap: add support to track dirty state of sub
 pages

On Thu, Aug 20, 2020 at 09:38:53AM +0800, yukuai (C) wrote:
> > > +iomap_set_range_dirty(struct page *page, unsigned int off,
> > > +		unsigned int len)
> > > +{
> > > +	if (PageError(page))
> > > +		return;
> > > +
> > > +	if (page_has_private(page))
> > > +		iomap_iop_set_range_dirty(page, off, len);
> > 
> > 
> > I vaguely remembered iomap doesn't always set up PagePrivate.
> > 
> 
> If so, maybe I should move iomap_set_page_dirty() to
> ioamp_set_range_dirty().

iomap sets PagePrivate if a iomap_page structure is allocated.  Right
now that means for all pages on a file system with a block size smaller
than the page size, although I hope we reduce that scope a little.