linux-kernel - Re: [PATCH 4.14 196/228] RDMA/ipoib: Return void from ipoib_ib_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Aug 2020 08:59:49 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kamal Heib <kamalheib1@...il.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.14 196/228] RDMA/ipoib: Return void from
 ipoib_ib_dev_stop()

Hi!

> From: Kamal Heib <kamalheib1@...il.com>
> 
> [ Upstream commit 95a5631f6c9f3045f26245e6045244652204dfdb ]
> 
> The return value from ipoib_ib_dev_stop() is always 0 - change it to be
> void.

AFAICT this is not a fixup, just a preparation for "RDMA/ipoib: Fix
ABBA deadlock with ipoib_reap_ah(", but we are not merging that for
4.14, so it should not be neccessary here.

Best regards,
								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)