linux-kernel - Re: [PATCH 0/9] TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Aug 2020 09:05:46 +0200
From:   Marco Elver <elver@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>, Will Deacon <will@...nel.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Jürgen Groß <jgross@...e.com>,
        "Paul E. McKenney" <paulmck@...nel.org>, rjw@...ysocki.net,
        Joel Fernandes <joel@...lfernandes.org>, svens@...ux.ibm.com,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage

On Fri, 21 Aug 2020 at 08:54, <peterz@...radead.org> wrote:
>
> On Thu, Aug 20, 2020 at 07:20:46PM +0200, Marco Elver wrote:
> > From 4ec9dd472c978e1eba622fb22bc04e4357f10421 Mon Sep 17 00:00:00 2001
> > From: Marco Elver <elver@...gle.com>
> > Date: Thu, 20 Aug 2020 19:06:09 +0200
> > Subject: [PATCH] sched: Turn inline into __always_inline due to noinstr use
> >
> > is_idle_task() may be used from noinstr functions such as
> > irqentry_enter(). Since the compiler is free to not inline regular
> > inline functions, switch to using __always_inline.
> >
> > Signed-off-by: Marco Elver <elver@...gle.com>
>
> Fair enough I suppose; didn't that generate an objtool warning on your
> build? (of course that requires PARAVIRT=n, I should get back to fixing
> that)

It does now after turning on VMLINUX_VALIDATION.

Although note that this patch (and the other, which I'll send
separately) wasn't required after the rcuidle fix. I suppose there is
still a small chance things can go wrong though, but syzkaller wasn't
able to find such a case (yet).

Thanks,
-- Marco