linux-kernel - Re: [PATCH 4.19 90/92] drm/radeon: fix fb_div check in ni_init_smc_spll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200821073715.GC1681156@kroah.com>
Date:   Fri, 21 Aug 2020 09:37:15 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Denis Efremov <efremov@...ux.com>,
        Alex Deucher <alexander.deucher@....com>
Subject: Re: [PATCH 4.19 90/92] drm/radeon: fix fb_div check in
 ni_init_smc_spll_table()

On Fri, Aug 21, 2020 at 09:27:18AM +0200, Pavel Machek wrote:
> Hi!
> 
> > From: Denis Efremov <efremov@...ux.com>
> > 
> > commit f29aa08852e1953e461f2d47ab13c34e14bc08b3 upstream.
> > 
> > clk_s is checked twice in a row in ni_init_smc_spll_table().
> > fb_div should be checked instead.
> > 
> > Fixes: 69e0b57a91ad ("drm/radeon/kms: add dpm support for cayman (v5)")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Denis Efremov <efremov@...ux.com>
> > Signed-off-by: Alex Deucher <alexander.deucher@....com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> No, this is wrong.
> 
> We already have the fix in -stable, as:
> 
> commit a083deda0b4179fb6780bc53d900794c4952339f
> Author: Denis Efremov <efremov@...ux.com>
> Date:   Mon Jun 22 23:31:22 2020 +0300
> 
>     drm/radeon: fix fb_div check in ni_init_smc_spll_table()
> 
>     commit 35f760b44b1b9cb16a306bdcc7220fbbf78c4789 upstream.
> 
> Result is that we now convert _second_ copy clk_s check, and check
> fb_div twice. This introduces error, rather than fixing one.

I hate the drm patchflow, it causes this type of issue to happen every
release.  It's their fault, they give me no way of detecting this type
of crap and seem to ignore my complaints :(

ugh.

greg k-h