[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200821074625.GA8336@alpha.franken.de>
Date: Fri, 21 Aug 2020 09:46:25 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Robert Richter <rric@...nel.org>, Huacai Chen <chenhc@...ote.com>,
Liangliang Huang <huanglllzu@...il.com>,
oprofile-list@...ts.sf.net, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: op_model_mipsxx: Fix non-executable code bug
On Tue, Aug 18, 2020 at 11:58:13PM -0500, Gustavo A. R. Silva wrote:
> The fallthrough pseudo-keyword is being wrongly used and is causing
> the non-executable code error below:
>
> arch/mips/oprofile/op_model_mipsxx.c: In function ‘mipsxx_perfcount_handler’:
> ./include/linux/compiler_attributes.h:214:41: warning: statement will never be executed [-Wswitch-unreachable]
> # define fallthrough __attribute__((__fallthrough__))
> ^
> arch/mips/oprofile/op_model_mipsxx.c:248:2: note: in expansion of macro ‘fallthrough’
> fallthrough; \
> ^~~~~~~~~~~
> arch/mips/oprofile/op_model_mipsxx.c:258:2: note: in expansion of macro ‘HANDLE_COUNTER’
> HANDLE_COUNTER(3)
> ^~~~~~~~~~~~~~
>
> Fix this by placing the fallthrough macro at the proper place.
>
> Fixes: c9b029903466 ("MIPS: Use fallthrough for arch/mips")
> Cc: stable@...r.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
> arch/mips/oprofile/op_model_mipsxx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
Powered by blists - more mailing lists