linux-kernel - Re: [PATCH 2/2] writeback: use DEFINE_WAIT_BIT instead of DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 21 Aug 2020 09:33:09 +0800
From:   Jacob Wen <jian.w.wen@...cle.com>
To:     linux-fsdevel@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-block@...r.kernel.org
Subject: Re: [PATCH 2/2] writeback: use DEFINE_WAIT_BIT instead of DEFINE_WAIT
 for bit wait queue

Can I have a review?

On 8/13/20 1:05 PM, Jacob Wen wrote:
> DEFINE_WAIT_BIT uses wake_bit_function() which is able to avoid
> false-wakeups due to possible hash collisions in the bit wait table.
>
> Signed-off-by: Jacob Wen <jian.w.wen@...cle.com>
> ---
>   fs/fs-writeback.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index a605c3dddabc..3bf751b33b48 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1354,16 +1354,16 @@ void inode_wait_for_writeback(struct inode *inode)
>   static void inode_sleep_on_writeback(struct inode *inode)
>   	__releases(inode->i_lock)
>   {
> -	DEFINE_WAIT(wait);
> +	DEFINE_WAIT_BIT(wait, &inode->i_state, __I_SYNC);
>   	wait_queue_head_t *wqh = bit_waitqueue(&inode->i_state, __I_SYNC);
>   	int sleep;
>   
> -	prepare_to_wait(wqh, &wait, TASK_UNINTERRUPTIBLE);
> +	prepare_to_wait(wqh, &wait.wq_entry, TASK_UNINTERRUPTIBLE);
>   	sleep = inode->i_state & I_SYNC;
>   	spin_unlock(&inode->i_lock);
>   	if (sleep)
>   		schedule();
> -	finish_wait(wqh, &wait);
> +	finish_wait(wqh, &wait.wq_entry);
>   }
>   
>   /*