linux-kernel - Re: [PATCH] mips/oprofile: Fix fallthrough placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Aug 2020 04:23:28 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     He Zhe <zhe.he@...driver.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     rric@...nel.org, oprofile-list@...ts.sf.net,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>
Subject: Re: [PATCH] mips/oprofile: Fix fallthrough placement



On 8/21/20 03:46, He Zhe wrote:
> 
> 
> On 8/21/20 3:48 PM, Thomas Bogendoerfer wrote:
>> On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe.he@...driver.com wrote:
>>> From: He Zhe <zhe.he@...driver.com>
>>>
>>> We want neither
>>> "
>>> include/linux/compiler_attributes.h:201:41: warning: statement will never
>>> be executed [-Wswitch-unreachable]
>>>   201 | # define fallthrough __attribute__((__fallthrough__))
>>>       |                      ^~~~~~~~~~~~~
>>> "
>>> nor
>>> "
>>> include/linux/compiler_attributes.h:201:41: warning: attribute
>>> 'fallthrough' not preceding a case label or default label
>>>   201 | # define fallthrough __attribute__((__fallthrough__))
>>>       |                      ^~~~~~~~~~~~~
>>> "
>>>
>>> It's not worth adding one more macro. Let's simply place the fallthrough
>>> in between the expansions.
>>>
>>> Signed-off-by: He Zhe <zhe.he@...driver.com>
>> there is already another patch for the problem, which I've applied
>> to mips-fixes.
> 
> You mean the below one?
> https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?h=mips-fixes&id=5900acb374fe2f4f42bbcb2c84db64f582d917a1
> 
> That patch handles the first warning in my commit log but does not handle the
> second one which is introduced since gcc v10.1.0 commit 6c80b1b56dec
> ("Make more bad uses of fallthrough attribute into pedwarns.").
> 

This is true.

Thomas, please apply this patch instead of mine. Also, consider adding
the Fixes tag and CC stable due to the non-executable code error, and
my Reviewed-by:

Fixes: c9b029903466 ("MIPS: Use fallthrough for arch/mips")
Cc: stable@...r.kernel.org
Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
--
Gustavo