linux-kernel - Re: [PATCH] ARM64: vdso32: Install vdso32 from vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f2a9b2b-bcb6-a719-1861-83ea8617eea6@arm.com>
Date:   Fri, 21 Aug 2020 11:56:01 +0100
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM64: vdso32: Install vdso32 from vdso_install

On 8/18/20 2:49 AM, Stephen Boyd wrote:
> Add the 32-bit vdso Makefile to the vdso_install rule so that 'make
> vdso_install' installs the 32-bit compat vdso when it is compiled.
> 
> Cc: Vincenzo Frascino <vincenzo.frascino@....com>
> Fixes: a7f71a2c8903 ("arm64: compat: Add vDSO")
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  arch/arm64/Makefile               | 1 +
>  arch/arm64/kernel/vdso32/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 55bc8546d9c7..b45f0124cc16 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -165,6 +165,7 @@ zinstall install:
>  PHONY += vdso_install
>  vdso_install:
>  	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso $@
> +	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso32 $@
>  
>  # We use MRPROPER_FILES and CLEAN_FILES now
>  archclean:
> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile
> index 5139a5f19256..d6adb4677c25 100644
> --- a/arch/arm64/kernel/vdso32/Makefile
> +++ b/arch/arm64/kernel/vdso32/Makefile
> @@ -208,7 +208,7 @@ quiet_cmd_vdsosym = VDSOSYM $@
>        cmd_vdsosym = $(NM) $< | $(gen-vdsosym) | LC_ALL=C sort > $@
>  
>  # Install commands for the unstripped file
> -quiet_cmd_vdso_install = INSTALL $@
> +quiet_cmd_vdso_install = INSTALL32 $@
>        cmd_vdso_install = cp $(obj)/$@...g $(MODLIB)/vdso/vdso32.so
>  
>  vdso.so: $(obj)/vdso.so.dbg
> 
> base-commit: 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
> 

-- 
Regards,
Vincenzo