linux-kernel - Re: [PATCH] locking/percpu-rwsem: Remove WQ_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200821111343.GC20455@willie-the-truck>
Date:   Fri, 21 Aug 2020 12:13:44 +0100
From:   Will Deacon <will@...nel.org>
To:     qiang.zhang@...driver.com
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] locking/percpu-rwsem: Remove WQ_FLAG_EXCLUSIVE flags

On Wed, Jul 01, 2020 at 01:57:20PM +0800, qiang.zhang@...driver.com wrote:
> From: Zqiang <qiang.zhang@...driver.com>
> 
> Remove WQ_FLAG_EXCLUSIVE from "wq_entry.flags", using function
> __add_wait_queue_entry_tail_exclusive substitution.
> 
> Signed-off-by: Zqiang <qiang.zhang@...driver.com>
> ---
>  kernel/locking/percpu-rwsem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/locking/percpu-rwsem.c b/kernel/locking/percpu-rwsem.c
> index 8bbafe3e5203..48e1c55c2e59 100644
> --- a/kernel/locking/percpu-rwsem.c
> +++ b/kernel/locking/percpu-rwsem.c
> @@ -148,8 +148,8 @@ static void percpu_rwsem_wait(struct percpu_rw_semaphore *sem, bool reader)
>  	 */
>  	wait = !__percpu_rwsem_trylock(sem, reader);
>  	if (wait) {
> -		wq_entry.flags |= WQ_FLAG_EXCLUSIVE | reader * WQ_FLAG_CUSTOM;
> -		__add_wait_queue_entry_tail(&sem->waiters, &wq_entry);
> +		wq_entry.flags |= reader * WQ_FLAG_CUSTOM;
> +		__add_wait_queue_entry_tail_exclusive(&sem->waiters, &wq_entry);
>  	}
>  	spin_unlock_irq(&sem->waiters.lock);

Seems straightforward enough:

Acked-by: Will Deacon <will@...nel.org>

Will