linux-kernel - Re: [PATCH v9 2/2] s390: virtio: PV needs VIRTIO I/O device protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19f742f8-8cc2-8f5a-90b0-c33e7b6a45b9@linux.ibm.com>
Date:   Fri, 21 Aug 2020 15:06:59 +0200
From:   Pierre Morel <pmorel@...ux.ibm.com>
To:     Cornelia Huck <cohuck@...hat.com>
Cc:     linux-kernel@...r.kernel.org, pasic@...ux.ibm.com,
        borntraeger@...ibm.com, frankja@...ux.ibm.com, mst@...hat.com,
        jasowang@...hat.com, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, thomas.lendacky@....com,
        david@...son.dropbear.id.au, linuxram@...ibm.com,
        hca@...ux.ibm.com, gor@...ux.ibm.com
Subject: Re: [PATCH v9 2/2] s390: virtio: PV needs VIRTIO I/O device
 protection



On 2020-08-21 14:05, Cornelia Huck wrote:
> On Wed, 19 Aug 2020 18:23:18 +0200
> Pierre Morel <pmorel@...ux.ibm.com> wrote:
> 
>> If protected virtualization is active on s390, VIRTIO has retricted
> 
> s/retricted/only restricted/
> 
>> access to the guest memory.
>> Define CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS and export
>> arch_has_restricted_virtio_memory_access to advertize VIRTIO if that's
>> the case, preventing a host error on access attempt.
>>
>> Signed-off-by: Pierre Morel <pmorel@...ux.ibm.com>
>> ---
>>   arch/s390/Kconfig   |  1 +
>>   arch/s390/mm/init.c | 11 +++++++++++
>>   2 files changed, 12 insertions(+)
> 
> (...)
> 
>> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
>> index 6dc7c3b60ef6..8febd73ed6ca 100644
>> --- a/arch/s390/mm/init.c
>> +++ b/arch/s390/mm/init.c
>> @@ -45,6 +45,7 @@
>>   #include <asm/kasan.h>
>>   #include <asm/dma-mapping.h>
>>   #include <asm/uv.h>
>> +#include <linux/virtio_config.h>
> 
> I don't think you need this include anymore.

right,
> 
>>   
>>   pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);
>>   
> 
> (...)
> 
> With the nit fixed,
> 
> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
> 

Thanks,

Pierre

-- 
Pierre Morel
IBM Lab Boeblingen