[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200821131512.348775-1-colin.king@canonical.com>
Date: Fri, 21 Aug 2020 14:15:12 +0100
From: Colin King <colin.king@...onical.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
wlanfae <wlanfae@...ltek.com>,
Larry Finger <Larry.Finger@...inger.net>,
Mike McCormack <mikem@...g3k.org>, devel@...verdev.osuosl.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: rtl8192e: fix missing failure check on a call to dev_alloc_name
From: Colin Ian King <colin.king@...onical.com>
Currently the second call to dev_alloc_name is not checking if this
failed. Add the check and perform necessary cleanup on an error.
Addresses-Coverity: ("Unchecked return value")
Fixes: 94a799425eee ("rtl8192e: Import new version of driver from realtek")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index fac58eebf263..7b15faeefff2 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -2489,7 +2489,8 @@ static int _rtl92e_pci_probe(struct pci_dev *pdev,
if (dev_alloc_name(dev, ifname) < 0) {
RT_TRACE(COMP_INIT,
"Oops: devname already taken! Trying wlan%%d...\n");
- dev_alloc_name(dev, ifname);
+ if (dev_alloc_name(dev, ifname) < 0)
+ goto err_unmap;
}
RT_TRACE(COMP_INIT, "Driver probe completed1\n");
--
2.27.0
Powered by blists - more mailing lists