linux-kernel - Re: [PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Aug 2020 15:20:59 +0200
From:   Stefan Agner <stefan@...er.ch>
To:     Chris Healy <cphealy@...il.com>
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        robh+dt@...nel.org, andrew.smirnov@...il.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, festevam@...il.com,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp

On 2020-08-20 06:10, Chris Healy wrote:
> From: Chris Healy <cphealy@...il.com>
> 
> Add syscon compatibility with Vybrid ocotp node. This is required to
> access the UID.

Hm, it seems today the SoC driver uses the specific compatible. It also
should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c.

Maybe it does make sense exposing it as syscon, but then we should
probably also adjust
Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.

--
Stefan

> 
> Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
> Cc: stable@...r.kernel.org
> Signed-off-by: Chris Healy <cphealy@...il.com>
> ---
> Changes in v2:
>  - Add Fixes line to commit message
> 
>  arch/arm/boot/dts/vfxxx.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 0fe03aa0367f..2259d11af721 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -495,7 +495,7 @@ edma1: dma-controller@...98000 {
>  			};
>  
>  			ocotp: ocotp@...a5000 {
> -				compatible = "fsl,vf610-ocotp";
> +				compatible = "fsl,vf610-ocotp", "syscon";
>  				reg = <0x400a5000 0x1000>;
>  				clocks = <&clks VF610_CLK_OCOTP>;
>  			};