linux-kernel - Re: [RFC PATCH V3 10/21] mmc: sdhci: UHS-II support, dump UHS-II registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Aug 2020 17:04:54 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Ben Chuang <benchuanggli@...il.com>, ulf.hansson@...aro.org
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        ben.chuang@...esyslogic.com.tw, takahiro.akashi@...aro.org,
        greg.tu@...esyslogic.com.tw
Subject: Re: [RFC PATCH V3 10/21] mmc: sdhci: UHS-II support, dump UHS-II
 registers

On 10/07/20 2:10 pm, Ben Chuang wrote:
> From: AKASHI Takahiro <takahiro.akashi@...aro.org>
> 
> Dump UHS-II specific registers, if available, in sdhci_dumpregs()
> for informative/debugging use.
> 
> Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>
> ---
>  drivers/mmc/host/sdhci.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 37b1158c1c0c..c2f6923d296c 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -111,6 +111,30 @@ void sdhci_dumpregs(struct sdhci_host *host)
>  		}
>  	}
>  
> +	if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) &&
> +	    host->mmc && host->mmc->flags & MMC_UHS2_SUPPORT) {
> +		SDHCI_DUMP("==================== UHS2 ==================\n");
> +		SDHCI_DUMP("Blk Size:  0x%08x | Blk Cnt:  0x%08x\n",
> +			   sdhci_readw(host, SDHCI_UHS2_BLOCK_SIZE),
> +			   sdhci_readl(host, SDHCI_UHS2_BLOCK_COUNT));
> +		SDHCI_DUMP("Cmd:       0x%08x | Trn mode: 0x%08x\n",
> +			   sdhci_readw(host, SDHCI_UHS2_COMMAND),
> +			   sdhci_readw(host, SDHCI_UHS2_TRANS_MODE));
> +		SDHCI_DUMP("Int Stat:  0x%08x | Dev Sel : 0x%08x\n",
> +			   sdhci_readw(host, SDHCI_UHS2_DEV_INT_STATUS),
> +			   sdhci_readb(host, SDHCI_UHS2_DEV_SELECT));
> +		SDHCI_DUMP("Dev Int Code:  0x%08x\n",
> +			   sdhci_readb(host, SDHCI_UHS2_DEV_INT_CODE));
> +		SDHCI_DUMP("Reset:     0x%08x | Timer:    0x%08x\n",
> +			   sdhci_readw(host, SDHCI_UHS2_SW_RESET),
> +			   sdhci_readw(host, SDHCI_UHS2_TIMER_CTRL));
> +		SDHCI_DUMP("ErrInt:    0x%08x | ErrIntEn: 0x%08x\n",
> +			   sdhci_readl(host, SDHCI_UHS2_ERR_INT_STATUS),
> +			   sdhci_readl(host, SDHCI_UHS2_ERR_INT_STATUS_EN));
> +		SDHCI_DUMP("ErrSigEn:  0x%08x\n",
> +			   sdhci_readl(host, SDHCI_UHS2_ERR_INT_SIG_EN));
> +	}
> +

Let's make this a host op instead ie.

	if (host->ops->dump_uhs2_regs)
		host->ops->dump_uhs2_regs(host);

>  	if (host->ops->dump_vendor_regs)
>  		host->ops->dump_vendor_regs(host);
>  
>