linux-kernel - Re: [PATCH 2/2] docs: RCU: Remove stray ()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Aug 2020 07:20:50 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     corbet@....net, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>, rcu@...r.kernel.org
Subject: Re: [PATCH 2/2] docs: RCU: Remove stray ()

On Fri, Aug 21, 2020 at 01:09:00PM +1200, Chris Packham wrote:
> A reference to srcu_read_lock_held() had an extra (). Remove it,
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Good eyes, but someone beat you to this one.

							Thanx, Paul

> ---
>  Documentation/RCU/lockdep.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/RCU/lockdep.rst b/Documentation/RCU/lockdep.rst
> index f1fc8ae3846a..cc860a0c296b 100644
> --- a/Documentation/RCU/lockdep.rst
> +++ b/Documentation/RCU/lockdep.rst
> @@ -49,7 +49,7 @@ checking of rcu_dereference() primitives:
>  		is invoked by both RCU-sched readers and updaters.
>  	srcu_dereference_check(p, c):
>  		Use explicit check expression "c" along with
> -		srcu_read_lock_held()().  This is useful in code that
> +		srcu_read_lock_held().  This is useful in code that
>  		is invoked by both SRCU readers and updaters.
>  	rcu_dereference_raw(p):
>  		Don't check.  (Use sparingly, if at all.)
> -- 
> 2.28.0
>