linux-kernel - RE: [PATCH v2] hv_utils: drain the timesync packets on onchannelcallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR2101MB10564E82C6F9628D8745FA84D75B0@SN6PR2101MB1056.namprd21.prod.outlook.com>
Date:   Fri, 21 Aug 2020 15:45:38 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Vineeth Pillai <viremana@...ux.microsoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>
CC:     KY Srinivasan <kys@...rosoft.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] hv_utils: drain the timesync packets on
 onchannelcallback

From: viremana@...ux.microsoft.com Sent: Friday, August 21, 2020 8:29 AM
> 
> There could be instances where a system stall prevents the timesync
> packaets to be consumed. And this might lead to more than one packet
> pending in the ring buffer. Current code empties one packet per callback
> and it might be a stale one. So drain all the packets from ring buffer
> on each callback.
> 
> Signed-off-by: Vineeth Pillai <viremana@...ux.microsoft.com>
> ---
> 
>  v2:
>     - s/pr_warn/pr_warn_once/
> 
> ---
>  drivers/hv/hv_util.c | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>