linux-kernel - Re: [PATCH] drivers: mmc: host: via-sdmmc: Fix data race bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200822061725.GA7141@madhuparna-HP-Notebook>
Date:   Sat, 22 Aug 2020 11:47:25 +0530
From:   Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     madhuparnabhowmik10@...il.com, Bruce Chang <brucechang@....com.tw>,
        Harald Welte <HaraldWelte@...tech.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ldv-project@...uxtesting.org, andrianov@...ras.ru
Subject: Re: [PATCH] drivers: mmc: host: via-sdmmc: Fix data race bug

On Fri, Aug 21, 2020 at 02:48:37PM +0200, Ulf Hansson wrote:
> On Mon, 3 Aug 2020 at 09:29, <madhuparnabhowmik10@...il.com> wrote:
> >
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> >
> > via_save_pcictrlreg() should be called with host->lock held
> > as it writes to pm_pcictrl_reg, otherwise there can be a race
> > condition between via_sd_suspend() and via_sdc_card_detect().
> > The same pattern is used in the function via_reset_pcictrl()
> > as well, where via_save_pcictrlreg() is called with host->lock
> > held.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> 
> This doesn't apply to my mmc tree, can you please rebase and submit a
> new version.
>
Sure, I have rebased it to v5.9-rc1, please have a look.

Thanks,
Madhuparna

> Kind regards
> Uffe
> 
> > ---
> >  drivers/mmc/host/via-sdmmc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c
> > index ef95bce50889..e4d8126cd4e5 100644
> > --- a/drivers/mmc/host/via-sdmmc.c
> > +++ b/drivers/mmc/host/via-sdmmc.c
> > @@ -1259,11 +1259,14 @@ static void via_init_sdc_pm(struct via_crdr_mmc_host *host)
> >  static int via_sd_suspend(struct pci_dev *pcidev, pm_message_t state)
> >  {
> >         struct via_crdr_mmc_host *host;
> > +       unsigned long flags;
> >
> >         host = pci_get_drvdata(pcidev);
> >
> > +       spin_lock_irqsave(&host->lock, flags);
> >         via_save_pcictrlreg(host);
> >         via_save_sdcreg(host);
> > +       spin_unlock_irqrestore(&host->lock, flags);
> >
> >         pci_save_state(pcidev);
> >         pci_enable_wake(pcidev, pci_choose_state(pcidev, state), 0);
> > --
> > 2.17.1
> >