lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Aug 2020 08:24:07 +0100 From: Chris Clayton <chris2553@...glemail.com> To: 吳昊澄 Ricky <ricky_wu@...ltek.com>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> Cc: LKML <linux-kernel@...r.kernel.org>, "rdunlap@...radead.org" <rdunlap@...radead.org>, "philquadra@...il.com" <philquadra@...il.com>, Arnd Bergmann <arnd@...db.de> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on Intel NUC boxes Hi Ricky. On 05/08/2020 13:48, Chris Clayton wrote: > Hi Ricky <snip> >> >> Ah, OK. I'll prepare the patch and send it to you once I've tested it. >> > > Please see the patch included below. As you suggested, it removes the code that does the OC power down on card readers > that are not members of your A series. The patch is against a fresh pull of Linus's tree this morning > (v5.8-2768-g4da9f3302615). > > I've tested the resultant kernel on my Intel NUC6CAYH box (which contains an NUC66AYB board) and the rts5229 works fine. > I've also tested it on my laptop which also has a card reader supported by the rtsx_pci driver (an RTL8411B) and that > also works fine. > > As I mentioned yesterday, I think it's a candidate for the 5.4 ans 5.7 stable series. > > Thanks for your patience! > > Chris > > Signed-off-by: Chris Clayton <chris2553@...glemail.com> > > --- a/drivers/misc/cardreader/rtsx_pcr.c 2020-08-05 07:10:21.752072515 +0100 > +++ b/drivers/misc/cardreader/rtsx_pcr.c 2020-08-05 07:11:05.568074278 +0100 > @@ -1172,10 +1172,6 @@ void rtsx_pci_init_ocp(struct rtsx_pcr * > rtsx_pci_write_register(pcr, REG_OCPGLITCH, > SD_OCP_GLITCH_MASK, pcr->hw_param.ocp_glitch); > rtsx_pci_enable_ocp(pcr); > - } else { > - /* OC power down */ > - rtsx_pci_write_register(pcr, FPDCTL, OC_POWER_DOWN, > - OC_POWER_DOWN); > } > } > } > > Is there some problem with my patch? If you are too busy to deal with it, perhaps I can submit directly it to Greg/Arnd. Thanks Chris
Powered by blists - more mailing lists