linux-kernel - [tip: x86/misc] x86/msr: Make source of unrecognised MSR writes unambiguous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159808936198.3192.9491971431453881525.tip-bot2@tip-bot2>
Date:   Sat, 22 Aug 2020 09:42:41 -0000
From:   "tip-bot2 for Chris Down" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Chris Down <chris@...isdown.name>, Borislav Petkov <bp@...e.de>,
        x86 <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: [tip: x86/misc] x86/msr: Make source of unrecognised MSR writes unambiguous

The following commit has been merged into the x86/misc branch of tip:

Commit-ID:     c31feed8461fb8648075ba9b53d9e527d530972f
Gitweb:        https://git.kernel.org/tip/c31feed8461fb8648075ba9b53d9e527d530972f
Author:        Chris Down <chris@...isdown.name>
AuthorDate:    Fri, 21 Aug 2020 13:10:35 +01:00
Committer:     Borislav Petkov <bp@...e.de>
CommitterDate: Sat, 22 Aug 2020 11:40:38 +02:00

x86/msr: Make source of unrecognised MSR writes unambiguous

In many cases, task_struct.comm isn't enough to distinguish the
offender, since for interpreted languages it's likely just going to be
"python3" or whatever. Add the pid to make it unambiguous.

 [ bp: Make the printk string a single line for easier grepping. ]

Signed-off-by: Chris Down <chris@...isdown.name>
Signed-off-by: Borislav Petkov <bp@...e.de>
Link: https://lkml.kernel.org/r/6f6fbd0ee6c99bc5e47910db700a6642159db01b.1598011595.git.chris@chrisdown.name
---
 arch/x86/kernel/msr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index b03001d..c0d4098 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -102,8 +102,8 @@ static int filter_write(u32 reg)
 	if (reg == MSR_IA32_ENERGY_PERF_BIAS)
 		return 0;
 
-	pr_err("Write to unrecognized MSR 0x%x by %s\n"
-	       "Please report to x86@...nel.org\n", reg, current->comm);
+	pr_err("Write to unrecognized MSR 0x%x by %s (pid: %d). Please report to x86@...nel.org.\n",
+	       reg, current->comm, current->pid);
 
 	return 0;
 }