lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 22 Aug 2020 13:56:36 +0200
From:   Krzysztof Kozlowski <>
To:     Markus Mayer <>
Cc:     Florian Fainelli <>,
        Colin Ian King <>,
        BCM Kernel Feedback <>,
        Linux ARM Kernel <>,
        Linux Kernel <>
Subject: Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote:
> We would overrun the error_text array if we hit a TIMEOUT condition,
> because we were using the error code "ETIMEDOUT" (which is 110) as an
> array index.
> We fix the problem by correcting the array index and by providing a
> function to retrieve error messages rather than accessing the array
> directly. The function includes a bounds check that prevents the array
> from being overrun.
> This patch was prepared in response to
> Signed-off-by: Markus Mayer <>

Your Signed-off-by does not match From field. Please run
scripts/checkpatch on every patch you send.

I fixed it up, assuming is the valid email

> Acked-by: Florian Fainelli <>
> ---
> Changes since v1:
>     - Added link of the coverity report to the commit message.
>     - Added Florian's ack.
>     - Removed second "const" from get_error_text() return type

Florian was so kind to provide you with necessary tags - Fixes and
Reported-by. Always include them on resubmit of patches.

Thanks, applied.

Best regards,

Powered by blists - more mailing lists