linux-kernel - Re: [PATCH net-next] net: Remove unnecessary intermediate variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200822.123315.787815838209253525.davem@davemloft.net>
Date:   Sat, 22 Aug 2020 12:33:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Jianlin.Lv@....com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, Song.Zhu@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: Remove unnecessary intermediate variables

From: Jianlin Lv <Jianlin.Lv@....com>
Date: Sat, 22 Aug 2020 10:04:31 +0800

> It is not necessary to use src/dst as an intermediate variable for
> assignment operation; Delete src/dst intermediate variables to avoid
> unnecessary variable declarations.
> 
> Signed-off-by: Jianlin Lv <Jianlin.Lv@....com>

It keeps the line lengths within reasonable length, so these local
variables are fine.

Also, the appropriate subsystem prefix for this patch should be "vxlan: "
not "net: " in your Subject line.  If someone is skimming the shortlog
in 'git' how will they tell where exactly in the networking your change
is being made?

Anyways, I'm not applying this, thanks.