linux-kernel - Re: [PATCH v33 12/12] LRNG - add power-on and runtime self-tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 23 Aug 2020 22:50:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stephan Müller <smueller@...onox.de>,
        Arnd Bergmann <arnd@...db.de>
Cc:     kbuild-all@...ts.01.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Alexander E. Patrakov" <patrakov@...il.com>,
        "Ahmed S. Darwish" <darwish.07@...il.com>,
        "Theodore Y. Ts'o" <tytso@....edu>, Willy Tarreau <w@....eu>
Subject: Re: [PATCH v33 12/12] LRNG - add power-on and runtime self-tests

Hi "Stephan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on cryptodev/master crypto/master v5.9-rc1 next-20200821]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200821-140523
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git d162219c655c8cf8003128a13840d6c1e183fb80
config: arm64-randconfig-s031-20200821 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-191-g10164920-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   aarch64-linux-ld: drivers/char/lrng/lrng_sw_noise.o: in function `add_interrupt_randomness':
>> drivers/char/lrng/lrng_sw_noise.c:113: undefined reference to `lrng_raw_irqflags_entropy_store'
   drivers/char/lrng/lrng_sw_noise.c:113:(.text+0x280): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `lrng_raw_irqflags_entropy_store'
>> aarch64-linux-ld: drivers/char/lrng/lrng_sw_noise.c:115: undefined reference to `lrng_raw_retip_entropy_store'
   drivers/char/lrng/lrng_sw_noise.c:115:(.text+0x2b4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `lrng_raw_retip_entropy_store'
   aarch64-linux-ld: drivers/char/lrng/lrng_sw_noise.c:131: undefined reference to `lrng_raw_retip_entropy_store'
   drivers/char/lrng/lrng_sw_noise.c:131:(.text+0x368): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `lrng_raw_retip_entropy_store'
>> aarch64-linux-ld: drivers/char/lrng/lrng_sw_noise.c:146: undefined reference to `lrng_raw_jiffies_entropy_store'
   drivers/char/lrng/lrng_sw_noise.c:146:(.text+0x3d4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `lrng_raw_jiffies_entropy_store'
>> aarch64-linux-ld: drivers/char/lrng/lrng_sw_noise.c:149: undefined reference to `lrng_raw_irqflags_entropy_store'
   drivers/char/lrng/lrng_sw_noise.c:149:(.text+0x3f0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `lrng_raw_irqflags_entropy_store'
   aarch64-linux-ld: drivers/char/lrng/lrng_sw_noise.c:152: undefined reference to `lrng_raw_retip_entropy_store'
   drivers/char/lrng/lrng_sw_noise.c:152:(.text+0x40c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `lrng_raw_retip_entropy_store'

sparse warnings: (new ones prefixed by >>)

>> drivers/char/lrng/lrng_selftest.c:53:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
>> drivers/char/lrng/lrng_selftest.c:53:22: sparse:     expected unsigned int [usertype]
>> drivers/char/lrng/lrng_selftest.c:53:22: sparse:     got restricted __le32 [usertype]
>> drivers/char/lrng/lrng_selftest.c:53:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
>> drivers/char/lrng/lrng_selftest.c:53:22: sparse:     expected unsigned int [usertype]
>> drivers/char/lrng/lrng_selftest.c:53:22: sparse:     got restricted __le32 [usertype]

# https://github.com/0day-ci/linux/commit/04c2864db01edca77a5a59da7b074dc191a30dd8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200821-140523
git checkout 04c2864db01edca77a5a59da7b074dc191a30dd8
vim +53 drivers/char/lrng/lrng_selftest.c

    46	
    47	static inline void lrng_selftest_bswap32(u32 *ptr, u32 words)
    48	{
    49		u32 i;
    50	
    51		/* Byte-swap data which is an LE representation */
    52		for (i = 0; i < words; i++) {
  > 53			*ptr = cpu_to_le32(*ptr);
    54			ptr++;
    55		}
    56	}
    57	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34730 bytes)