linux-kernel - Re: [PATCH] scsi: scsi_debug: Remove superfluous close zone in resp_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 23 Aug 2020 23:44:32 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     Niklas Cassel <Niklas.Cassel@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: scsi_debug: Remove superfluous close zone in
 resp_open_zone()

On 2020/08/21 22:00, Niklas Cassel wrote:
> resp_open_zone() always calls zbc_open_zone() with parameter explicit
> set to true.
> 
> If zbc_open_zone() is called with parameter explicit set to true, and
> the current zone state is implicit open, it will call zbc_close_zone()
> on the zone before proceeding.
> 
> Therefore, there is no need for resp_open_zone() to call zbc_close_zone()
> on an implicitly open zone before calling zbc_open_zone().
> 
> Remove superfluous close zone in resp_open_zone().
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@....com>
> ---
>  drivers/scsi/scsi_debug.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 064ed680c0530..912d6f4878bae 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -4482,8 +4482,6 @@ static int resp_open_zone(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
>  		goto fini;
>  	}
>  
> -	if (zc == ZC2_IMPLICIT_OPEN)
> -		zbc_close_zone(devip, zsp);
>  	zbc_open_zone(devip, zsp, true);
>  fini:
>  	write_unlock(macc_lckp);
> 

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@....com>

-- 
Damien Le Moal
Western Digital Research