linux-kernel - Re: [PATCH v3 1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200823031227.GT30094@dragon>
Date:   Sun, 23 Aug 2020 11:12:28 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Chris Healy <cphealy@...il.com>
Cc:     srinivas.kandagatla@...aro.org, robh+dt@...nel.org,
        andrew.smirnov@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, stefan@...er.ch,
        linux-arm-kernel@...ts.infradead.org, stable@...r.kernel.org,
        festevam@...il.com
Subject: Re: [PATCH v3 1/2] dt-bindings: nvmem: Add syscon to Vybrid OCOTP
 driver

On Fri, Aug 21, 2020 at 02:21:01PM -0700, Chris Healy wrote:
> From: Chris Healy <cphealy@...il.com>
> 
> Add syscon compatibility with Vybrid OCOTP driver binding. This is
> required to access the UID.
> 
> Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")

The bindings doc was not added by this commit though.

> Cc: stable@...r.kernel.org
> Signed-off-by: Chris Healy <cphealy@...il.com>
> ---
>  Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> index 56ed481c3e26..5db39f399568 100644
> --- a/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> +++ b/Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt
> @@ -11,7 +11,7 @@ Required Properties:
>  Example for Vybrid VF5xx/VF6xx:
>  
>  	ocotp: ocotp@...a5000 {
> -		compatible = "fsl,vf610-ocotp";
> +		compatible = "fsl,vf610-ocotp", "syscon";

It's not only about fixing example.  More important one is "compatible"
property of the bindings.

Shawn

>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		reg = <0x400a5000 0xCF0>;
> -- 
> 2.26.2
>