lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 24 Aug 2020 14:22:06 +0300
From:   Dan Carpenter <>
To:     Tomer Samara <>
Cc:     Greg Kroah-Hartman <>,, Todd Kjos <>,
        Suren Baghdasaryan <>,
        Riley Andrews <>,,,
        Hridya Valsaraju <>,
        Arve Hjønnevåg <>,
        Joel Fernandes <>,
        Laura Abbott <>,
        Martijn Coenen <>,
        Sumit Semwal <>,
        Christian Brauner <>
Subject: Re: [PATCH v4 1/2] staging: android: Remove BUG_ON from

On Fri, Aug 21, 2020 at 06:27:37PM +0300, Tomer Samara wrote:
> BUG_ON() is removed at ion_page_pool.c
> Fixes the following issue:
> Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON().
> Signed-off-by: Tomer Samara <>
> ---

You should put a note here about what changed between v3 vs v4. Like so:
v4: Just remove the BUG_ON()s instead of adding new returns.
v3: Hand the new return paths or whatever.

Anyway, looks good.

Reviewed-by: Dan Carpenter <>

dan carpenter

Powered by blists - more mailing lists