linux-kernel - Re: [PATCH] netlink: remove duplicated nla_need_padding_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <51bd2b4c5f4549488de08bdcf6daae23@huawei.com>
Date:   Mon, 24 Aug 2020 11:58:24 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "johannes.berg@...el.com" <johannes.berg@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] netlink: remove duplicated nla_need_padding_for_64bit()
 check

friendly ping :)

>Miaohe Lin <linmiaohe@...wei.com> wrote:
>From: Miaohe Lin <linmiaohe@...wei.com>
>
>The need for padding 64bit is implicitly checked by nla_align_64bit(), so remove this explicit one.
>
>Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>---
> lib/nlattr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/lib/nlattr.c b/lib/nlattr.c index bc5b5cf608c4..98f596bfbfd8 100644
>--- a/lib/nlattr.c
>+++ b/lib/nlattr.c
>@@ -816,8 +816,7 @@ EXPORT_SYMBOL(__nla_reserve);  struct nlattr *__nla_reserve_64bit(struct sk_buff *skb, int attrtype,
> 				   int attrlen, int padattr)
> {
>-	if (nla_need_padding_for_64bit(skb))
>-		nla_align_64bit(skb, padattr);
>+	nla_align_64bit(skb, padattr);
> 
> 	return __nla_reserve(skb, attrtype, attrlen);  }
>--
>2.19.1
>