linux-kernel - Re: [PATCH 10/11] ima: Don't ignore errors from crypto_shash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ccf18096bf715d0eb8f68899c324452a4b044124.camel@linux.ibm.com>
Date:   Mon, 24 Aug 2020 09:02:22 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>, mjg59@...gle.com
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, silviu.vlasceanu@...wei.com,
        stable@...r.kernel.org
Subject: Re: [PATCH 10/11] ima: Don't ignore errors from
 crypto_shash_update()

On Thu, 2020-06-18 at 18:04 +0200, Roberto Sassu wrote:
> Errors returned by crypto_shash_update() are not checked in
> ima_calc_boot_aggregate_tfm() and thus can be overwritten at the next
> iteration of the loop. This patch adds a check after calling
> crypto_shash_update() and returns immediately if the result is not zero.
> 
> Cc: stable@...r.kernel.org
> Fixes: 3323eec921efd ("integrity: IMA as an integrity service provider")
> Signed-off-by: Roberto Sassu <roberto.sassu@...wei.com>

Verification of the boot_aggregate will fail, but yes this should be
fixed.  This patch  and the next should be moved up front to the
beginning of the patch set.

Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>

thanks,

Mimi