linux-kernel - Re: [PATCH] watchdog: sbsa_gwdt: add shutdown hook to driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Aug 2020 06:28:59 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Qiang Zhao <qiang.zhao@....com>, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: sbsa_gwdt: add shutdown hook to driver

On 8/24/20 1:18 AM, Qiang Zhao wrote:
> From: Zhao Qiang <qiang.zhao@....com>
> 
> Kexec maybe need more time than timeout of wdt(sbsa)
> which will reset the system.
> So it is necessary to add shutdown hook to disable the
> wdt when run kexec.
> 

Please explain why watchdog_stop_on_reboot() does not work.

Thanks,
Guenter

> Signed-off-by: Zhao Qiang <qiang.zhao@....com>
> ---
>  drivers/watchdog/sbsa_gwdt.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index f0f1e3b..bbcd04d 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -313,6 +313,14 @@ static int sbsa_gwdt_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static void sbsa_gwdt_shutdown(struct platform_device *pdev)
> +{
> +	struct sbsa_gwdt *gwdt;
> +
> +	gwdt = platform_get_drvdata(pdev);
> +	sbsa_gwdt_stop(&gwdt->wdd);
> +}
> +
>  /* Disable watchdog if it is active during suspend */
>  static int __maybe_unused sbsa_gwdt_suspend(struct device *dev)
>  {
> @@ -357,6 +365,7 @@ static struct platform_driver sbsa_gwdt_driver = {
>  		.pm = &sbsa_gwdt_pm_ops,
>  		.of_match_table = sbsa_gwdt_of_match,
>  	},
> +	.shutdown = sbsa_gwdt_shutdown,
>  	.probe = sbsa_gwdt_probe,
>  	.id_table = sbsa_gwdt_pdev_match,
>  };
>